-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(creator): standardizing Actiontypes and making all plugin actions optional #74
Conversation
🦋 Changeset detectedLatest commit: d83370e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: 0 B Total Size: 23.3 kB ℹ️ View Unchanged
|
This looks good but I think we're going to need to make some related changes in the registry to prevent breakage and make sure they're handled consistently there too. |
what's the registry? |
I couldn't find a reason that bridge, swap, and mint are required while all other action types are optional - they're already typed to throw an error.
Also, Burn was using DelegateActionParams so I made it use BurnActionParams - no plugins are using Burn yet