Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(creator): standardizing Actiontypes and making all plugin actions optional #74

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

gnomadic
Copy link
Contributor

@gnomadic gnomadic commented Feb 2, 2024

I couldn't find a reason that bridge, swap, and mint are required while all other action types are optional - they're already typed to throw an error.

Also, Burn was using DelegateActionParams so I made it use BurnActionParams - no plugins are using Burn yet

@gnomadic gnomadic requested a review from a team as a code owner February 2, 2024 05:07
Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: d83370e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Size Change: 0 B

Total Size: 23.3 kB

ℹ️ View Unchanged
Filename Size
dist/cjs/abi/erc20-quest.js 1.13 kB
dist/cjs/abi/erc20.js 578 B
dist/cjs/abi/quest-factory.js 2.08 kB
dist/cjs/actions/index.js 231 B
dist/cjs/actions/types.js 345 B
dist/cjs/constants.js 342 B
dist/cjs/errors/base.js 734 B
dist/cjs/errors/plugin.js 229 B
dist/cjs/errors/quest.js 331 B
dist/cjs/errors/utils.js 257 B
dist/cjs/errors/version.js 157 B
dist/cjs/filter/filters.js 1.71 kB
dist/cjs/filter/index.js 308 B
dist/cjs/filter/operators.js 268 B
dist/cjs/filter/types.js 124 B
dist/cjs/index.js 641 B
dist/cjs/quests/approveIfNeeded.js 525 B
dist/cjs/quests/constants.js 295 B
dist/cjs/quests/deployQuest.js 573 B
dist/cjs/quests/index.js 356 B
dist/cjs/quests/types.js 124 B
dist/cjs/utils/chains.js 375 B
dist/cjs/utils/compressJson.js 255 B
dist/cjs/utils/index.js 280 B
dist/esm/abi/erc20-quest.js 1.07 kB
dist/esm/abi/erc20.js 522 B
dist/esm/abi/quest-factory.js 2.02 kB
dist/esm/actions/index.js 100 B
dist/esm/actions/types.js 286 B
dist/esm/constants.js 303 B
dist/esm/errors/base.js 678 B
dist/esm/errors/plugin.js 158 B
dist/esm/errors/quest.js 276 B
dist/esm/errors/utils.js 164 B
dist/esm/errors/version.js 91 B
dist/esm/filter/filters.js 2.12 kB
dist/esm/filter/index.js 135 B
dist/esm/filter/operators.js 162 B
dist/esm/filter/types.js 64 B
dist/esm/index.js 323 B
dist/esm/quests/approveIfNeeded.js 688 B
dist/esm/quests/constants.js 310 B
dist/esm/quests/deployQuest.js 494 B
dist/esm/quests/index.js 175 B
dist/esm/quests/types.js 64 B
dist/esm/utils/chains.js 448 B
dist/esm/utils/compressJson.js 279 B
dist/esm/utils/index.js 133 B

compressed-size-action

@gnomadic gnomadic changed the title fix(builder): standardizing Actiontypes and making all plugin actions optional fix(creator): standardizing Actiontypes and making all plugin actions optional Feb 2, 2024
@Quazia
Copy link
Member

Quazia commented Feb 5, 2024

This looks good but I think we're going to need to make some related changes in the registry to prevent breakage and make sure they're handled consistently there too.

@rabbitholegg rabbitholegg locked and limited conversation to collaborators Feb 5, 2024
@rabbitholegg rabbitholegg unlocked this conversation Feb 5, 2024
@gnomadic
Copy link
Contributor Author

gnomadic commented Feb 5, 2024

This looks good but I think we're going to need to make some related changes in the registry to prevent breakage and make sure they're handled consistently there too.

what's the registry?

@gnomadic gnomadic merged commit 3d5a2ff into main Feb 7, 2024
@gnomadic gnomadic deleted the plugin-builder branch February 7, 2024 21:33
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants