-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure code is formatted #147
Conversation
16c69b3
to
0a8d7e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a few cosmetic adjustments in mind. I'll assign you as reviewer after I push my changes 👀
For some reason, it is failing in GitHub actions |
2549a7c
to
8de15e7
Compare
Ok, so the problem is that the Action merges the PR, somehow, and then runs our It's not the best developer experience, but it ensures that folks rebase their branches against the Why it doesn't fail on windoze is a mystery to me ❗ Mistery solved: windows build does not run |
@lukebakken we can merge main into your feature branch (ugh, imo), or rebase the feature branch against the main branch. Then |
@Zerpet do whatever works. I certainly don't mind if you force push to my branch because actually it shouldn't affect me locally and if it does, whatever. I'll check this out tomorrow. |
Also bump Windows dep versions
- Clarifications - Formatting Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
Signed-off-by: Aitor Pérez Cedres <acedres@vmware.com>
8de15e7
to
4be4230
Compare
Also bump Windows dep versions