khepri_machine: Do not enforce favor options in machine state queries
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] We want to leave the caller decide the consistency it wants. Also, there is a problem with leader and consistent queries in Ra because the function is executed on a remote node and the function reference or the MFA may not be valid, leading to an exception. [How] We just stop setting the `favor` option.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 88.96% 88.95% -0.01%
==========================================
Files 20 20
Lines 2917 2915 -2
==========================================
- Hits 2595 2593 -2
Misses 322 322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to leave the caller decide the consistency it wants.
Also, there is a problem with leader and consistent queries in Ra because the function is executed on a remote node and the function reference or the MFA may not be valid, leading to an exception.
How
We just stop setting the
favoroption.