Fixes to khepri_cluster member queries
#287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why]
Other functions use the uniform `{error, _}` return value for errors and
already convert `{timeout, _}` term to conform to that.
The functions that query Ra members or nodes didn't do that so far, even
though the type spec said otherwise.
[Why] Even if the time out was reached while retrying `ra:member/2` after a `noproc` error, the code would continue to retry because it never checked the remaining time.
... or a few other errors related to inter-node connection issues. [Why] We want to use the given timeout to give another chance to success.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 89.62% 89.64% +0.01%
==========================================
Files 21 21
Lines 3124 3130 +6
==========================================
+ Hits 2800 2806 +6
Misses 324 324
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
the-mikedavis
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a set of patches to fix the functions to query Ra members and nodes in
khepri_cluster:noproc.noconnectionerror and a few other related errors.