Support custom connect uri through annotation on rabbitmqcluster #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirahImage
approved these changes
Jun 28, 2023
- allow connection uri to be overwritten by annotation in rabbitmqcluster
ChunyiLyu
force-pushed
the
uri-annotation
branch
from
f828234
to
bf99eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue rabbitmq/cluster-operator#1185
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Users can configure their RabbitMQ connection URI by setting annotation
rabbitmq.com/operator-connection-uriin their rabbitmqcluster. This should be a more user friendly way of customizing URI to the rabbitmqcluster instead of creating an addition secret object.Additional Context