Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer handler messages async #40

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Consumer handler messages async #40

merged 1 commit into from
Aug 13, 2024

Conversation

Gsantomaggio
Copy link
Member

  • delivery context async
  • refactor logs

@Gsantomaggio Gsantomaggio marked this pull request as ready for review July 30, 2024 13:41
@lukebakken lukebakken marked this pull request as draft August 9, 2024 22:21
@lukebakken lukebakken self-requested a review August 9, 2024 22:21
@lukebakken lukebakken self-assigned this Aug 9, 2024
@lukebakken lukebakken added this to the 0.1.0 milestone Aug 9, 2024
@lukebakken lukebakken marked this pull request as ready for review August 12, 2024 23:27
@Gsantomaggio @lukebakken
Consumer handler messages async
4364927 
- delivery context async
- refactor logs

Signed-off-by: Gabriele Santomaggio <g.santomaggio@gmail.com>

* Rename `ConnectionName` to `ContainerId` to match AMQP 1.0 spec
* Fix `PauseShouldStopMessageArrivalUnpauseShouldResumeIt` test and add some more assertions to it.
* Get the credits right for consumers.
* Remove some unnecessary output
* Adjust tests to use `queueName` variable
@lukebakken lukebakken merged commit c88a80b into main Aug 13, 2024
1 check passed
@lukebakken lukebakken deleted the misc branch August 13, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken Awaiting requested review from lukebakken

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gsantomaggio @lukebakken