Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BuildAsync to BuildAndStartAsync #60

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Rename BuildAsync to BuildAndStartAsync #60

merged 1 commit into from
Sep 5, 2024

Conversation

Gsantomaggio
Copy link
Member

Closes: #59

@Gsantomaggio
Rename BuildAsync to BuildAndStartAsync
74d46f0 
Closes: #59

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
lukebakken
lukebakken approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@lukebakken lukebakken merged commit 706269d into main Sep 5, 2024
2 checks passed
@lukebakken lukebakken deleted the rename_build_async branch September 5, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantics of IConsumer.BuildAsync() start consume.
2 participants
@Gsantomaggio @lukebakken