Fix exception when refreshing oauth2 token #1690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This fixes a small bug that happens when refreshing the OAuth2 access token from the OAuth backchannel provider. The dictionary key "scope" in BuildRefreshParameters is already set in BuildRequestParameters and therefore this throws an exception.
Types of Changes
Checklist
CONTRIBUTING.md
documentFurther Comments
Before being added to the dictionary, _scope undergoes two different checks: Nullability and string.IsNullOrEmpty in the two aforementioned methods. I do not know if this is intentional or not.