Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Make statistics collection and aggregation distributed across all cluster nodes #298

Merged
merged 177 commits into from
Dec 1, 2016
Merged

Make statistics collection and aggregation distributed across all cluster nodes #298

merged 177 commits into from
Dec 1, 2016

Conversation

kjnilsson
Copy link
Contributor

Fixes #236

dcorbacho and others added 30 commits August 31, 2016 08:12
@dcorbacho
Remove unused code for the new mgmt stats
347d551
@dcorbacho
Include original exometer_slide
931ebd1
@dcorbacho
Collect connection metrics
4292fcd
@dcorbacho
Handle connection_closed event
fdd64fb
@dcorbacho
Channel metrics. Implements aggregation
f9e5861
@dcorbacho
Handle channel_closed event
73ac8eb
@dcorbacho
Filter detailed stats
5e18729
@dcorbacho
Consumer stats
9523350
@dcorbacho
Exchange stats
53f8445
@dcorbacho
Queue stats
9e8d162
@dcorbacho
Check if queue and exchange exist
49f124d
@dcorbacho
Handle deleted events
e1a9d60
@dcorbacho
Handle vhost_deleted
96ebc4a
@dcorbacho
Node stats
4a8253d
@dcorbacho
Handle node node stats
e6d1cec
@dcorbacho
Fix vhost stats
e03a347
@dcorbacho
Overview stats
fc6bb7e
@dcorbacho
Remove unused code
84e4199
@dcorbacho
Update exometer_slide copyright note
039009a
@dcorbacho
Change mirrored supervisor to normal one
043d266
@dcorbacho
Remove unused defines
73b8666
@dcorbacho
Query consumers
16b0e0d
@dcorbacho
Format queried stats
1ec1552
@dcorbacho
Fix escaping of records on select queries
81a01cf
@dcorbacho
Fix formatting of queries results and skip connection details if not …
037e9e5 
…yet available
@dcorbacho
Re-introduce rabbit_mgmt_sup_sup for an easy restart
503a194
@dcorbacho
Mgmt memory report and test
ff45a36
@kjnilsson
Implement statistic_db_event_queue
95abb03
@dcorbacho
Clean empty stats
edc8053
@dcorbacho
Add lookups for testing
18d7bf9
kjnilsson and others added 16 commits November 23, 2016 14:40
@kjnilsson
exometer_slide:to_list should realise the last sample
507f860
@kjnilsson
Round timestamps when normalizing instead of ceil
9bb6f7b
@kjnilsson
Remove problematic clause from maybe_add_last_sample
0074ea1
@kjnilsson
Padding fixes and test adjustments
e5319a6
@kjnilsson
Use MFA instead of funs
07bb6c8
@kjnilsson
db_cache_multiplier -> management_db_cache_multiplier
0d6f6ea
@kjnilsson
Ensure drop expansion is bounded
cb7742d
@kjnilsson
Set last timestamp when summing slides
00fc96f
@kjnilsson
Ensure buffers are swapped even when input values are being dropped
de1fce2
@kjnilsson
Slightly reduce the chances of incorrect padding at the end of the sl…
2445b83 
…iding window.

Refactor exometer_slide:sum.
@kjnilsson
Delay slide summing until formatting to avoid normalizing twice. Now …
862bf68 
…uses ceil as only normalization strategy.

Dialyzer fixes and refactoring
@kjnilsson
Fix issue where the slide would occasionally zero pad incorrectly
5d58a9b
@kjnilsson
Increase range for mgmt_test_db time-sensitive tests
6812ac9
@dumbbell
Makefile: Convert from CRLF (Dos) to LF (Unix) newlines
71cb693
@dumbbell
Merge branch 'stable' into rabbitmq-management-236
5ee5233
@dumbbell
Makefile: Do not pin rabbitmq_web_dispatch version
4b679d9 
Let rabbitmq-components.mk do its "magic".
michaelklishin
michaelklishin suggested changes Nov 24, 2016
View reviewed changes
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that Consumer Utilization is always displayed as NaN%.

To reproduce:

  • Declare 100 queues, with a consumer on each one
  • Publish to them in a loop, sequentially, possibly in bursts

The rates are non-0 as expected but Consumer Utilization stays at NaN%.

michaelklishin and others added 9 commits November 25, 2016 01:01
@michaelklishin
Copy
56eb381
@kjnilsson
Reduce GC operations by keeping the old stats in each collector
78320bd 
process instead of ETS.
@kjnilsson
Tidy up removal of the old_aggr_stats table
662a72c
@kjnilsson
Move collectors and related modules to rabbitmq_management_agent
95259eb
@essen
Fix CORS preflight requests
aaf2276 
Credentials are never sent with preflight requests, and preflight
requests are only accepted if they return successfully (eg 200).
We returned a 401 when credentials were missing so browsers rejected
the response.
@kjnilsson
Move rabbit_mgmt_format and mochiweb_util to rabbitmq_management_agent
4a83f7d
@kjnilsson
Test tidy up
d5ce58b
@michaelklishin
Merge branch 'stable'
e1eb20f 
Conflicts:
	Makefile
@dcorbacho
Comments cleanup
5f3e1a0
@michaelklishin michaelklishin self-assigned this Dec 1, 2016
@michaelklishin michaelklishin changed the title DO NOT MERGE - Make statistics collection and aggregation distributed across all cluster nodes Make statistics collection and aggregation distributed across all cluster nodes Dec 1, 2016
@michaelklishin michaelklishin merged commit 3495b4b into stable Dec 1, 2016
@dumbbell dumbbell deleted the rabbitmq-management-236 branch January 3, 2018 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelklishin michaelklishin michaelklishin requested changes

Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kjnilsson @michaelklishin @ztmr @dcorbacho @essen @dumbbell