This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Make requeue the default option in the Get Messages section to avoid accidentally deleting messages #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Change the order of the Ack Mode drop down under the Get Messages section of a Queue so that requeue is the first / default option.
The proposed change is so that users do not accidentally remove messages from the queue without confirming that they should be permanently deleted. This is only a UI change and does not affect any logic of the Get operation.
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out aftercreating the PR. If you're unsure about any of them, don't hesitate to
ask on the mailing list. We're here to help! This is simply a reminder
of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
Before:
After: