Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Make requeue the default option in the Get Messages section to avoid accidentally deleting messages #542

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

dparkinson
Copy link
Contributor

Proposed Changes

Change the order of the Ack Mode drop down under the Get Messages section of a Queue so that requeue is the first / default option.

The proposed change is so that users do not accidentally remove messages from the queue without confirming that they should be permanently deleted. This is only a UI change and does not affect any logic of the Get operation.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)
  • Usability (improved user interaction)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask on the mailing list. We're here to help! This is simply a reminder
of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

Before:
requeue-default-before

After:
requeue-default-after

@michaelklishin
Copy link
Member

Our team agrees this is a good idea. I am QA'ing it.

@michaelklishin michaelklishin merged commit cebe3e2 into rabbitmq:master Jan 18, 2018
michaelklishin added a commit that referenced this pull request Jan 18, 2018
@michaelklishin
Copy link
Member

Thank you!

michaelklishin added a commit that referenced this pull request Jan 18, 2018
References #542.

[#154449209]

(cherry picked from commit 334ed37)
lukebakken pushed a commit to Jinkxed/rabbitmq-management that referenced this pull request Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants