This repository has been archived by the owner on Nov 17, 2020. It is now read-only.
Downgrade QoS2 messages to QoS1 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. We should update the docs to say that QoS 2 is upgraded to QoS 1, too. |
michaelklishin
added a commit
that referenced
this pull request
Jan 27, 2016
Downgrade QoS2 messages to QoS1
|
👍 Please submit a docs PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21.
Replace QoS2 is treated as QoS1.
It's not quite correct, because spec mention that QoS2 messages sent to a QoS0 topic should not be duplicated, while QoS1 messages could be duplicated.
But RabbitMQ should not duplicate
no_ack=truemessages anyway.