Skip access check on absent will queue #11023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #11021 Prior to this commit, an MQTT client that connects to RabbitMQ needed configure access to its will queue even if the will queue has never existed. This breaks client apps connecting with either v3 or v4 or with v5 without making use of the Will-Delay-Interval. Specifically, in 3.13.0 and 3.13.1 an MQTT client that connects to RabbitMQ needs unnecessarily configure access to queue `mqtt-will-<MQTT client ID>`. This commit only check for configure access, if the queue actually gets deleted, i.e. if it existed.
michaelklishin
approved these changes
Apr 17, 2024
Merged
ansd
added a commit
that referenced
this pull request
Apr 22, 2024
Fix the failing GitHub action Test Authentication/Authorization backends via mutiple messaging protocols / selenium originally caused by #11023
ansd
added a commit
that referenced
this pull request
Apr 22, 2024
Fix the failing GitHub action Test Authentication/Authorization backends via mutiple messaging protocols / selenium originally caused by #11023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11021
Prior to this commit, an MQTT client that connects to RabbitMQ needed configure access to its will queue even if the will queue has never existed. This breaks client apps connecting with either v3 or v4 or with v5 without making use of the Will-Delay-Interval.
Specifically, in 3.13.0 and 3.13.1 an MQTT client that connects to RabbitMQ needs unnecessarily configure access to queue
mqtt-will-<MQTT client ID>.This commit only check for configure access, if the queue actually gets deleted, i.e. if it existed.