Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added global default queue type config #11163

Merged
merged 2 commits into from
May 3, 2024

Conversation

SimonUnge
Copy link
Member

Proposed Changes

A global setting for the default queue type. precedence would be x-queue-type -> vhost-default-queue-type -> config queue type -> rabbit_classic_queue

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution
you did and what alternatives you considered, etc.

@michaelklishin
Copy link
Member

FTR, this was discussed with me and is just a global default for what already can be configured using virtual host metadata.

Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quorum => rabbit_quorum_queue translation can be done in a Cuttlefish translation, plus it would allow us to support arbitrary values (module names).

We already do that for the peer discovery mechanism.

@SimonUnge
Copy link
Member Author

SimonUnge commented May 3, 2024

Thanks @michaelklishin , updated the code!

@SimonUnge SimonUnge marked this pull request as draft May 3, 2024 19:45
@SimonUnge SimonUnge marked this pull request as ready for review May 3, 2024 19:47
@michaelklishin michaelklishin added this to the 3.13.3 milestone May 3, 2024
@michaelklishin michaelklishin merged commit b49b9a8 into rabbitmq:main May 3, 2024
11 checks passed
michaelklishin added a commit that referenced this pull request May 4, 2024
Added global default queue type config (backport #11163)
michaelklishin added a commit that referenced this pull request May 4, 2024
Added global default queue type config (backport #11163) (backport #11164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants