Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure shovels to wait until all sources and destinations are declared (backport #11793) #11823

Merged
merged 13 commits into from
Jul 24, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 24, 2024

Proposed Changes

it addresses feature request #10501

Doc's PR => rabbitmq/rabbitmq-website#1987

Dynamic shovels

You can configure the plugin to either always declare the missing source and/or destination queues or instead wait until they are declared, for instance, once the definitions file is imported at node boot up. In the latter case, shovel will try to passively declare the resource until it succeeds. It uses the reconnection_delay to wait between attempts.

To configure the plugin to wait until the resources are available, apply the following configuration to rabbitmq.conf:

shovel.topology.predeclared = true

To configure individual shovels to wait until either the source and/or destination are available, apply these key-pair values to the shovel parameter:

dest-predeclared = true
src-predeclared = true

Shovel parameters take precedence over plugin configuration values.

Static shovels

Static shovels wait until the queue exists provided it is configured with shovel.topology.predeclared = true and the shovel's source has no declarations or it is empty.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

This is an automatic backport of pull request #11793 done by [Mergify](https://mergify.com).

MarcialRosales and others added 13 commits July 24, 2024 22:28
(cherry picked from commit 5465b44)
(cherry picked from commit a888c7b)
(cherry picked from commit 48f1bc7)
(cherry picked from commit c24756e)
(cherry picked from commit 55bc5a2)
(cherry picked from commit 17e470e)
(cherry picked from commit ae17c6c)
(cherry picked from commit 61c9cf2)
when a socket is closed before a writer tries
to flush it.

(cherry picked from commit 5161aea)
@mergify mergify bot added the bazel label Jul 24, 2024
@michaelklishin michaelklishin merged commit 19c4ac5 into v4.0.x Jul 24, 2024
189 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v4.0.x/pr-11793 branch July 24, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants