Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By @Hathoute: consider additional_scopes_key when multiple OAuth 2 backends are used #12752

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented Nov 18, 2024

This is #12751 by @Hathoute. I'm re-submitting it so that all Actions can run with access to GH secrets.

Closes #12750.

@michaelklishin michaelklishin changed the title By @hathoute: consider additional_scopes_key when multiple OAuth 2 backends are used By @Hathoute: consider additional_scopes_key when multiple OAuth 2 backends are used Nov 18, 2024
(cherry picked from commit 6459111)
@michaelklishin
Copy link
Member Author

@MarcialRosales this is now ready for you to review.

@michaelklishin michaelklishin added this to the 4.1.0 milestone Nov 18, 2024
@MarcialRosales
Copy link
Contributor

Yes, I approve these changes. Thanks @Hathoute for fixing it. In fact, I was planning on just leaving the setting additional_scopes_key and deprecating extra_scopes_key just to avoid this type of problems.

@michaelklishin michaelklishin merged commit 0081e1d into main Nov 19, 2024
271 checks passed
@michaelklishin michaelklishin deleted the rabbitmq-server-12751-by-hathoute branch November 19, 2024 10:20
michaelklishin added a commit that referenced this pull request Nov 19, 2024
michaelklishin added a commit that referenced this pull request Nov 19, 2024
michaelklishin added a commit that referenced this pull request Nov 19, 2024
By @Hathoute: consider additional_scopes_key when multiple OAuth 2 backends are used (backport #12752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'additional_scopes_key' ignored when configuring multiple oauth2 resource servers
3 participants