By @gomoripeti: Streams: two additional Prometheus metrics for connections #12765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that they can be used from multiple test suites. (cherry picked from commit cf8a00c)
Supports both per stream (detailed) and aggregated (metrics) values. (cherry picked from commit e82058e)
(cherry picked from commit 0c76054)
The application is not always recompiled which causes tests to fail because they cannot call `serial_number:usort/1`. (cherry picked from commit 05a3733)
12 tasks
|
I have received no objections to this PR from other core team members. |
|
This seems safe to backport to |
|
@gomoripeti backporting to |
michaelklishin
added a commit
that referenced
this pull request
Nov 20, 2024
|
thank you. This feature is not super urgent for us so 4.1.0 sounds good. And I take a note of manually backporting to 4.0.x if time permits. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #10275 by @gomoripeti re-submitted so that Actions have access to all the GH secrets.