Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth 2: JWT token refresh should preserve user identity displayed in the UI #12818

Merged
merged 1 commit into from
Nov 27, 2024
Merged

OAuth 2: JWT token refresh should preserve user identity displayed in the UI #12818

merged 1 commit into from
Nov 27, 2024

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Nov 26, 2024 •
edited by michaelklishin
Loading

Proposed Changes

Closes #12598

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Nov 26, 2024
@MarcialRosales MarcialRosales force-pushed the token-refresh-cannot-change-username branch 2 times, most recently from 85e1622 to 5bcaa5d Compare November 27, 2024 09:36
@MarcialRosales MarcialRosales force-pushed the token-refresh-cannot-change-username branch from 5bcaa5d to 3718fe3 Compare November 27, 2024 09:41
@MarcialRosales MarcialRosales marked this pull request as ready for review November 27, 2024 10:53
@michaelklishin michaelklishin added this to the 4.1.0 milestone Nov 27, 2024
@michaelklishin michaelklishin changed the title Token refresh cannot change username OAuth 2: JWT token refresh should preserve user identity displayed in the UI Nov 27, 2024
@michaelklishin michaelklishin merged commit 7da1c8a into main Nov 27, 2024
271 checks passed
@michaelklishin michaelklishin deleted the token-refresh-cannot-change-username branch November 27, 2024 12:28
@mergify mergify bot mentioned this pull request Nov 27, 2024
Merged
6 tasks
michaelklishin added a commit that referenced this pull request Nov 29, 2024
@michaelklishin
Merge pull request #12831 from rabbitmq/mergify/bp/v4.0.x/pr-12818
5b90d1a 
OAuth 2: JWT token refresh should preserve user identity displayed in the UI (backport #12818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin Awaiting requested review from michaelklishin

Assignees

@MarcialRosales MarcialRosales

Labels
backport-v4.0.x
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

Refreshed OAuth2 tokens should preserve the user's identity
2 participants
@MarcialRosales @michaelklishin