rabbit_quorum_queue: Wait for member add in add_member/4
#12837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
wait-for-commit-in-rabbit_quorum_queue-add_member
branch
from
2aeade5 to
b51fcf2
Compare
dumbbell
force-pushed
the
wait-for-commit-in-rabbit_quorum_queue-add_member
branch
from
b51fcf2 to
2402d3d
Compare
[Why] The `ra:member_add/3` call returns before the change is committed. This is ok for that addition but any follow-up changes to the cluster might be rejected with the `cluster_change_not_permitted` error. [How] Instead of changing other places to wait or retry their cluster membership change, this patch waits for the current add to be applied before proceeding and returning. This fixes some transient failures in CI where such follow-up changes are rejected and not retried, leaving the cluster in an unexpected state for the testcase. An example is with `quorum_queue_SUITE:force_shrink_member_to_current_member/1`
dumbbell
force-pushed
the
wait-for-commit-in-rabbit_quorum_queue-add_member
branch
from
2402d3d to
99d8e90
Compare
kjnilsson
approved these changes
Nov 28, 2024
michaelklishin
deleted the
wait-for-commit-in-rabbit_quorum_queue-add_member
branch
michaelklishin
added a commit
that referenced
this pull request
Nov 28, 2024
rabbit_quorum_queue: Wait for member add in `add_member/4` (backport #12837)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
ra:member_add/3call returns before the change is committed. This is ok for that addition but any follow-up changes to the cluster might be rejected with thecluster_change_not_permittederror.How
Instead of changing other places to wait or retry their cluster membership change, this patch waits for the current add to be applied before proceeding and returning.
This fixes some transient failures in CI where such follow-up changes are rejected and not retried, leaving the cluster in an unexpected state for the testcase.
An example is with
quorum_queue_SUITE:force_shrink_member_to_current_member/1