Fix transient queue detection #12840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check fails on a virin node, because the metadata store is not yet ready to handle the query. However, a virin node by definition can't have any queues, so let's just return false without asking.
This fixes the issue where RabbitMQ would warn about transient queues being used in a cluster with no transient queues. Fixes #12802
michaelklishin
approved these changes
Nov 27, 2024
michaelklishin
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
I have confirmed the effectiveness of this.
With both
deprecated_features.permit.transient_nonexcl_queues = trueand
deprecated_features.permit.transient_nonexcl_queues = falsethe behavior is now what I'd expect: only transient, non-exclusive classic queues trigger a warning or, with the 2nd configuration file, the node refuses to perform the declaration.
Transient exclusive or durable queues do not trigger the warning and can be declared in both cases.
michaelklishin
added a commit
that referenced
this pull request
Nov 28, 2024
Fix transient queue detection (backport #12840)
akarl
pushed a commit
to 0x4b53/amqp-rpc
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two separate issues in the same area:
Invalid pattern leading to an incorrect warning about transient queues being used (because all durable queues were counted).
Fixes "Deprecated features are being used" for transient_nonexcl_queues even when there are no transient queues in the cluster #12802
A fresh deployment wouldn't boot with
deprecated_features.permit.transient_nonexcl_queues = falseFixes Node runs into an exception failed_to_deny_deprecated_features on boot when try to deactivate deprecated feature #12793