Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure rabbit_misc:pmap callbacks do not throw. #1477

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Make sure rabbit_misc:pmap callbacks do not throw. #1477

merged 2 commits into from
Jan 24, 2018

Conversation

hairyhum
Copy link
Contributor

@hairyhum hairyhum commented Jan 19, 2018 •
edited
Loading

[#153846585]

Proposed Changes

Catch any errors in callbacks for rabbit_misc:pmap/2

rabbit_misc:pmap/2 can hang if a callback throws an error.
This can cause plugin startup to hang when enabling channel
interceptors.

Made it log errors and continue.

Types of Changes

What types of changes does your code introduce to this project?

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin changed the title DO NOT MERGE Make sure rabbit_misc:pmap callbacks do not throw. Make sure rabbit_misc:pmap callbacks do not throw. Jan 23, 2018
@hairyhum
Make sure rabbit_misc:pmap callbacks do not throw.
189a452 
rabbit_misc:pmap/2 can hang if a callback throws an error.
This can cause plugin startup to hang when enabling channel
interceptors.
Made it log errors and continue.

[#153846585]
@hairyhum hairyhum force-pushed the rabbitmq-server-channel-interceptor-hang branch from 04f0b13 to 189a452 Compare January 24, 2018 10:52
@hairyhum hairyhum changed the base branch from master to v3.7.x January 24, 2018 10:52
@hairyhum
Copy link
Contributor Author

Rebased to 3.7

@hairyhum
Add a test to check channel interceptor hang.
5570b18 
The test can hang without channel interceptor fix
and will fail with timetrap timeout

[#153846585]
@michaelklishin michaelklishin merged commit cef9d18 into v3.7.x Jan 24, 2018
@lukebakken lukebakken deleted the rabbitmq-server-channel-interceptor-hang branch January 25, 2018 00:49
@michaelklishin michaelklishin added this to the 3.7.3 milestone Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@hairyhum @michaelklishin