Faster implementation of rabbit_binding:recover/0 #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a large number of bindings, this implementation reduces the recovery time from minutes to seconds. rabbit_binding:recover/2 is the second operation that may take minutes but it can be improved separately.
lhoguin
approved these changes
Jun 23, 2021
michaelklishin
added a commit
that referenced
this pull request
Jun 29, 2021
Faster implementation of rabbit_binding:recover/0 (cherry picked from commit a3e98c2)
michaelklishin
added a commit
that referenced
this pull request
Jun 29, 2021
|
Backported to |
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a large number of bindings, this implementation reduces
rabbit_binding:recover/0execution from minutes to seconds. rabbit_binding:recover/2 can still take minutes but it can be improved separately.
Before:
After:
That's 136s to 83s for a test with 16k queues and 275k bindings.