Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info during the error parse message #284

Merged
merged 4 commits into from
Sep 3, 2023
Merged

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Sep 1, 2023

Add more info during the error parse message.
Add more tests form messages coming from AMQP 0_9_1

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.03% 🎉

Comparison is base (942493d) 93.01% compared to head (2af3854) 93.04%.

❗ Current head 2af3854 differs from pull request most recent head f0b9514. Consider uploading reports for the commit f0b9514 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   93.01%   93.04%   +0.03%     
==========================================
  Files         110      110              
  Lines        9604     9640      +36     
  Branches      761      764       +3     
==========================================
+ Hits         8933     8970      +37     
+ Misses        514      511       -3     
- Partials      157      159       +2     
Files Changed Coverage Δ
RabbitMQ.Stream.Client/RawConsumer.cs 85.55% <0.00%> (-0.24%) ⬇️
Tests/FromToAMQPTests.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio marked this pull request as ready for review September 1, 2023 13:47
@Gsantomaggio Gsantomaggio merged commit 8a85779 into main Sep 3, 2023
2 checks passed
@Gsantomaggio Gsantomaggio deleted the add_info_parse branch September 3, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants