Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication to handle the pool #356

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Feb 9, 2024

Small improvement

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (66cbd13) 92.00% compared to head (9fc0846) 92.20%.

Files Patch % Lines
RabbitMQ.Stream.Client/ConnectionsPool.cs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   92.00%   92.20%   +0.19%     
==========================================
  Files         116      116              
  Lines       11738    11738              
  Branches      916      915       -1     
==========================================
+ Hits        10800    10823      +23     
+ Misses        733      709      -24     
- Partials      205      206       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gsantomaggio Gsantomaggio marked this pull request as ready for review February 9, 2024 12:17
@Gsantomaggio Gsantomaggio merged commit 335a0f3 into main Feb 9, 2024
2 checks passed
@Gsantomaggio Gsantomaggio deleted the remove_duplication branch February 9, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant