New guide: Cluster Formation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which documents automatic cluster formation procedure and the pluggable peer discovery mechanisms introduced in 3.7.0.
acogoluegnes
requested changes
Nov 14, 2016
| </p> | ||
|
|
||
| <p> | ||
| Nodes that previously were cluster members will try to contact |
There was a problem hiding this comment.
This sentence needs rewording.
| <doc:heading>DNS Peer Discovery Backend</doc:heading> | ||
|
|
||
| <p> | ||
| Another build-in peer discovery mechanism as of RabbitMQ 3.7.0 is DNS-based. |
dcorbacho
requested changes
Nov 14, 2016
| The following example in the classic config format. The 2nd | ||
| member of the <code>rabbit.cluster_nodes</code> tuple is the | ||
| node type to use for the current node. In the vast majority of | ||
| cases all nodes should be <code>disc</code>nodes. |
There was a problem hiding this comment.
Missing space between disc and nodes
| </pre> | ||
| </p> | ||
| <p> | ||
| The following example in the classic config format. The 2nd |
There was a problem hiding this comment.
Missing the verb on this sentence. Maybe uses the classic config format?
| <code>autocluster.peer_discovery_backend</code> is the key | ||
| that controls what discovery module (implementation) is used. | ||
| The module has to implement the <a | ||
| href="https://github.com/rabbitmq/rabbitmq-server/blob/master/src/rabbit_peer_discovery.erl">rabbit_peer_discovery</a> |
There was a problem hiding this comment.
It should be rabbit_peer_discovery_backend at https://github.com/rabbitmq/rabbitmq-common/blob/master/src/rabbit_peer_discovery_backend.erl
|
Should be corrected now. |
acogoluegnes
requested changes
Nov 14, 2016
| </p> | ||
|
|
||
| <p> | ||
| If a node node previously was a cluster member, it will try to contact |
There was a problem hiding this comment.
"node node" => "node"
dcorbacho
approved these changes
Nov 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which documents automatic cluster formation procedure and
the pluggable peer discovery mechanisms introduced in 3.7.0.
Part of rabbitmq/rabbitmq-server#988 as well as rabbitmq/rabbitmq-server#486.