Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rack 3 #586

Merged
merged 15 commits into from
Jul 25, 2023
Merged

Support rack 3 #586

merged 15 commits into from
Jul 25, 2023

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Aug 3, 2022

We should probably also update CI, but we've been testing rack-attack from the rack repo (external tests) and all the tests are passing. So this should probably be good.


Closes #596

gemfiles/rack_3.gemfile Outdated Show resolved Hide resolved
gemfiles/rack_3.gemfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@grzuy grzuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you!

I think to have the test pass we would additionally need to point the rack_3 appraisal to a version of actionpack that actually compatible with rack 3.

gemfiles/rack_3.gemfile Show resolved Hide resolved
gemfiles/rack_3.gemfile Outdated Show resolved Hide resolved
@grzuy
Copy link
Collaborator

grzuy commented Oct 16, 2022

I think to have the test pass we would additionally need to point the rack_3 appraisal to a version of actionpack that actually compatible with rack 3.

This depends on rails/rails#45741 being merged first probably.

@grzuy grzuy mentioned this pull request Oct 24, 2022
@grzuy grzuy changed the title Update rack-attack.gemspec Suppor rack 3 Oct 24, 2022
@grzuy grzuy changed the title Suppor rack 3 Support rack 3 Oct 24, 2022
@halostatue
Copy link

What's blocking this from being merged?

@jeremyevans
Copy link

I think CI needs to be green for the PR before we can consider merging. No issues with the PR itself, though.

@ioquatix
Copy link
Member Author

ioquatix commented Dec 17, 2022

It looks like this is blocked on rails/rails#46594 and indirectly rails/rails#46206 - @rafaelfranca FYI.

I'm going to try and rework the dependencies so we don't pull in railties when testing rack 3... it might allow us to get tests passing.

@smridge
Copy link

smridge commented Mar 23, 2023

From what I'm seeing, this will work if rails edge is used now that the version restriction has been relaxed here

@fayeroske
Copy link

Any updates here? Similarly blocked trying to remediate CVE-2022-30122 by upgrading to rack 3.0.

@xxswingxx
Copy link

Since rails/rails#46206 was merged, it's just rails/rails#46594 blocking this one?

@ioquatix
Copy link
Member Author

Sorry, I totally forgot about this PR. I'll take a look at it in the next few days.

@nedim-symphony
Copy link

@ioquatix Hello, any updates on this?

@tsmartt
Copy link

tsmartt commented Jul 12, 2023

Same, any update? And thanks for the library!

@colemanja91
Copy link

Also checking in, would love to get our apps up to Rack 3, blocked on this

@ioquatix ioquatix dismissed jeremyevans’s stale review July 25, 2023 03:16

Feedback addressed.

@ioquatix ioquatix merged commit b708de3 into main Jul 25, 2023
@ioquatix ioquatix deleted the allow-rack-3 branch July 25, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rack 3 Support