Avoid RedisCacheStore#increment on Rails 6+

[jdelStrother]

As far as I can tell, Rails has handled increment+expires_in since
6.0 (rails/rails@9d5b02e), and more recent versions add pipeline optimizations on top of that.

How about avoiding our own custom RedisCacheStoreProxy#increment method on modern versions of ActiveSupport?

This also avoids an extra GET (from the if options[:expires_in] && !read(name) call).

[jdelStrother]

Let me know if there's interest in merging this & I'll rebase.

[mitchellhenke]

I'd really like to see it land.

In some brief local application-level benchmarking, the patch is quite a bit faster. In simpler applications or situations where Redis latency is worse, I suspect the impact would be even larger. Using derailed_benchmarks:

❤️ ❤️ ❤️  (Statistically Significant) ❤️ ❤️ ❤️

(0.2698 seconds) "rack attack update"
  FASTER 🚀🚀🚀 by:
    1.0643x [older/newer]
    6.0431% [(older - newer) / older * 100]
(0.2872 seconds) "main"

Iterations per sample: 200
Samples: 200

Test type: Kolmogorov Smirnov
Confidence level: 99.0 %
Is significant? (max > critical): true
D critical: 0.15174271293851463
D max: 0.66

[grzuy]

Let me know if there's interest in merging this & I'll rebase.

Yes, please.

Thank you.

[jdelStrother]

It looks like there's test failures with redis-activesupport against ActiveSupport 7.1.1 - it tries to use Integer#present? and Hash#symbolize_keys without requiring them from ActiveSupport.

I've fixed it by adding the requires to spec/acceptance/stores/active_support_redis_store_spec.rb for now, though could see an argument for adding them to lib/rack/attack/store_proxy/active_support_redis_store_proxy.rb.
(Ideally it would be fixed in the redis-activesupport gem, but since it's in Archive status, that seems unlikely)

[grzuy]

Makes sense!

Thank you!

Pending conflicts with latest changes in main.

[jdelStrother]

I'm away for a few weeks, but can pick this up again in November.

[santib]

Hi, I think this is a nice improvement 👏

I was checking the PR and noticed that there are no tests for ActiveSupport < 6, so went ahead and added:

# gemfiles/active_support_5_redis_cache_store.gemfile

source "https://rubygems.org"

gem "activesupport", "~> 5.2.0"
gem "redis", "~> 5.0"

gemspec path: "../"

When running the tests BUNDLE_GEMFILE=gemfiles/active_support_5_redis_cache_store.gemfile bundle exec rake test I got a couple of failures. After some debugging seems like defined?(ActiveSupport) isn't behaving well, and instead we need to do if defined?(::ActiveSupport).

EDIT:
The gemfile for ActiveSupport 5 was merged. When updating this branch with main the CI should fail because of the above

[mitchellhenke]

I'm very interested in seeing this merged, is there anything I can do to help move it forward?

[santib]

Hi @mitchellhenke, I think we are waiting for @jdelStrother to fix the CI and that should be it 👌

He said he was out til November, so he'll probably be coming back soon.

[jdelStrother]

Yep, let me try & take a look at it today

[jdelStrother]

Rebased and fixed the defined?(ActiveSupport) check, though Github Actions seems to be having a bad day - could you re-run the failed ones?

[santib]

Thanks for your contribution @jdelStrother 🙌