Do not use removed Rack 2.0 bytesize method
#124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please merge this or add @maclover7 as a maintainer :) |
|
Breaks compat with Rack < 2.0 on Ruby < 2, though. We'd need to branch and version-bump rack-contrib to Ruby 2+ and Rack 2+ before this. |
|
ruby-grape/grape#1464 is related |
|
Closing this in favour of #137, which contains this fix and several others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @mpalmer @tenderlove
Rack::Utils#bytesizewas removed in rack/rack@7b5820f.