fix: cookie-av allows arbitrary casing #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
requested changes
Nov 26, 2024
lib/rack/test/cookie_jar.rb
Outdated
| @@ -28,7 +28,7 @@ def initialize(raw, uri = nil, default_host = DEFAULT_HOST) | |||
| @raw, options = raw.split(/[;,] */n, 2) | |||
|
|
|||
| @name, @value = parse_query(@raw, ';').to_a.first | |||
| @options = parse_query(options, ';') | |||
| @options = parse_query(options, ';').transform_keys(&:downcase) | |||
There was a problem hiding this comment.
rack-test supports back to Ruby 2.0, so you'll have to change this to use a backwards-compatible implementation.
There was a problem hiding this comment.
I think I introduced a correct fix but I'm currently installing 2.0.0p0 to confirm
There was a problem hiding this comment.
I have not managed to install 2.0.0, I'm now going to hope CI runs for it
According to [RFC6265](https://httpwg.org/specs/rfc6265.html#sane-set-cookie), cookie attributes are supposed to be ~PascalCase (`Path`, `HttpOnly`, `Secure`, etc). In practice, browsers are lax in their interpretation of cookie attributes and will allow arbitrary casing (`path`, `Path`, `pAtH`, etc). Prior to this PR, `Rack::Test::Cookie` only supported lowercased cookie attributes, but this PR allows it to have any casing, making it behave closer to browsers and other cookie jars. https://github.com/python/cpython/blob/f0d3f10c43c9029378adba11a65b3d1287e4be32/Lib/http/cookiejar.py#L511-L512 https://cs.opensource.google/go/go/+/master:src/net/http/cookie.go;l=126-131;drc=592da0ba474b94b6eceee62b5613f1c9c1ed9c89?q=cookie&ss=go%2Fgo
gmalette
force-pushed
the
gm/cookie-av-allow-uppsercased-names
branch
from
dfd71de to
1e4a44a
Compare
gmalette
commented
Nov 27, 2024
lib/rack/test/cookie_jar.rb
Outdated
| @@ -28,7 +28,7 @@ def initialize(raw, uri = nil, default_host = DEFAULT_HOST) | |||
| @raw, options = raw.split(/[;,] */n, 2) | |||
|
|
|||
| @name, @value = parse_query(@raw, ';').to_a.first | |||
| @options = parse_query(options, ';') | |||
| @options = parse_query(options, ';').map { |k, v| [k.downcase, v] }.to_h | |||
There was a problem hiding this comment.
I guess Array#to_h was added in 2.1 :(
|
Thanks for working on this and getting CI fixed. I squash merged this at 16a3c5c. |
|
Thanks a lot for handling it this fast! |
|
Would you be able to cut a release that includes this please? |
|
It has been a while since the last release, so I can try to do that before the end of the year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC6265, cookie attributes are supposed to be ~PascalCase (
Path,HttpOnly,Secure, etc). In practice, browsers are lax in their interpretation of cookie attributes and will allow arbitrary casing (path,Path,pAtH, etc).Prior to this PR,
Rack::Test::Cookieonly supported lowercased cookie attributes, but this PR allows it to have any casing, making it behave closer to browsers and other cookie jars.Python
Go