Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The response array must always be non-frozen. #1927

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Jul 9, 2022

No description provided.

@ioquatix ioquatix requested a review from jeremyevans July 9, 2022 07:12
@ioquatix
Copy link
Member Author

ioquatix commented Jul 9, 2022

@jeremyevans going to assume you are happy with this as discussed in #1887 - if not just let me know and I'll fix up any issues.

@ioquatix ioquatix force-pushed the mutable-response-array branch from 5489769 to c562896 Compare July 9, 2022 07:13
Copy link
Contributor

@jeremyevans jeremyevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please make sure to add this to CHANGELOG.

@ioquatix ioquatix force-pushed the mutable-response-array branch from c562896 to 3d91d65 Compare July 9, 2022 07:22
@ioquatix ioquatix merged commit 1206f3b into main Jul 9, 2022
@ioquatix ioquatix deleted the mutable-response-array branch July 9, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants