Allow Rack::Builder#run to take a block instead of an argument.
#1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
rack-builder-run-block
branch
from
cc4192c to
9fd4936
Compare
jeremyevans
requested changes
Aug 4, 2022
Merged
simi
approved these changes
Aug 4, 2022
jeremyevans
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was first introduced to rack many years ago, I recalled that this particular part of the
config.rucaused me a lot of initial confusion.I think we should allow
run {|env| ...}to work, it's more canonical Ruby and it's easy for new users to understand since they don't need to learn about multiple concepts (e.g. lambdas).I can't see any major downsides to accepting this, except it will mean older servers won't be compatible with the new syntax, but I think that's an acceptable trade off given how many other things are also changing.