chore: some refactoring of the workflow code and names #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the supplied logging level instead of hardcoding it to DEBUG.
Added a common helper to default nautobot args and test it.
Make all the scripts support the common nautobot args as input.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
skrobul
approved these changes
Aug 22, 2024
Shorten to use "sync" instead of "synchronize" since k8s cuts some things off at 63 characters so this will make it less likely to hit that limit. Cleaned up the naming across the board including the workflows and the source code.
cardoe
force-pushed
the
clean-up-workflows
branch
from
eb2e39b
to
6f33a3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored some of the workflow code to use a common nautobot url/token parser, with tests. Trimmed the name synchronize to sync. Created a common spot for shared fixtures.