feat: create ironic hooks to set resource class #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it can be installed along with sushy-oem package
After giving this some thought, matching multiple machines in one go is YAGNI.
Both traditional redfish and idrac rely on the same elements of inventory, so extract the common code and use the inventory everywhere. Prior to this, the redfish driver relied on properties instead, but they were just a copies that also exist in inventory.
skrobul
changed the title
skrobul
changed the title
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
skrobul
force-pushed
the
PUC-433-create-ironic-hooks-to-set-resource-class
branch
2 times, most recently
from
d023d14
to
b38b5a9
Compare
Scoring logic should live in the FlavorSpec and provide an easy way to obtain score for a given Machine. This reduces Matcher functionality to simply interacting with a collection of flavors and matching them against Machine.
skrobul
force-pushed
the
PUC-433-create-ironic-hooks-to-set-resource-class
branch
from
b38b5a9
to
3c434b5
Compare
cardoe
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Python package that enhances Ironic's functionality by automatically setting the resource_class on Nodes.
The package parses the contents of the Flavors YAML defined in the undercloud-nautobot-device-types repository, and during Node inspection, it cross-checks the received inventory data against the defined flavors.
This feature supports both in-band (inspect_interface set to agent) and out-of-band inspection methods (redfish-understack and idrac-redfish-understack).
The specification repository is automatically synced to the local hostPath volume. However, changes will only take effect after the ironic-conductor is restarted.
Closes PUC-433