Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change eb1 expected test results to #true #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haroldcarr
Copy link
Contributor

Even though y is free, it seems the grammar allows this. So expected results were wrong.

@wilbowma
Copy link
Collaborator

wilbowma commented Jul 4, 2017

The text of the tutorial still explains that eb1 shouldn't be a lambda?. My guess is that the test is right, but the implementation of lambda? is not as the author intended. Probably, anything that binds the same name twice in the same argument list should not be a lambda?. Alternatively, the grammar is wrong and should be somehow enforcing uniqueness of names.

@haroldcarr
Copy link
Contributor Author

It seems to me that the text LATER changes the Lambda definition to disallow repeated parameters. But at this point in the text Lambda does allow them. lambda? checks Lambda. It seems to me that the test value is incorrect.

@wilbowma
Copy link
Collaborator

wilbowma commented Jul 4, 2017

Oh that's a good point. In that case, I wonder if the failing test was a rhetorical device from a lecture and should be expected to fail. I'll leave that to @rfindler.

@rfindler
Copy link
Member

rfindler commented Jul 4, 2017

I did do some attempt to get these into running shape (but apparently not enough), but the lecture notes were originally @mfelleisen 's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants