Add make targets for cleaning db and inserting fake data. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 94.57% 94.49% -0.09%
==========================================
Files 107 107
Lines 4570 4576 +6
Branches 258 260 +2
==========================================
+ Hits 4322 4324 +2
- Misses 208 211 +3
- Partials 40 41 +1
Continue to review full report at Codecov.
|
jerbob
approved these changes
Jun 10, 2021
This reverts commit 56690b9.
|
That is both terrible practice and wont work because you have to pass coverage on the latest commit. |
this is common practice |
This reverts commit 0cc9936.
This reverts commit 71d8c08.
0xAda
added a commit
that referenced
this pull request
Sep 26, 2024
* Add make targets for cleaning db and inserting fake data. * Update Makefile * Set Plugin logs to INFO * Add 'docopt' to dev-dependencies * Update 'fake' script * Update __init__.py * Remove clean_db.py * Update black line length (what's scope?) * Remove clean_db.py * Format scripts/fake * Update scripts.fake * Split long SQL statement * Update __main__.py * Update __main__.py * Update __main__.py * fix clean db Co-authored-by: Jeremiah Boby <mail@jeremiahboby.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds make targets insert-data, insert-bulk-data, clean-db, and clean-test. Also speeds up the data insertion by roughly 2x