Add healthchecks to docker-compose.yml #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
- Coverage 94.41% 94.34% -0.08%
==========================================
Files 107 107
Lines 4767 4671 -96
Branches 272 269 -3
==========================================
- Hits 4501 4407 -94
+ Misses 223 221 -2
Partials 43 43
Continue to review full report at Codecov.
|
|
Thanks, Jeremiah. This looks good to me. Merging. |
Adds django-healthcheck to the project dependencies, as well as the relevant 'curl' command to the service's healthcheck. I've also added the relevant 'pg_isready' healthcheck to the database service, which allows us to remove the netcat check from our entrypoint scripts.
0xAda
force-pushed
the
feature/compose-database-healthcheck
branch
from
9e89ec2 to
ea216e1
Compare
|
Hi @jerbob, can you resolve conflicts here? It looks good to merge after that. Thanks! |
| "health_check.cache", | ||
| "health_check.storage", | ||
| "health_check.contrib.migrations", | ||
| "health_check.contrib.psutil", |
There was a problem hiding this comment.
This should be handled by the host.
| "health_check.contrib.psutil", |
|
We think it may be good here to factor out the |
Co-authored-by: Johannes Christ <jc@jchri.st>
Co-authored-by: Johannes Christ <jc@jchri.st>
Co-authored-by: Johannes Christ <jc@jchri.st>
Co-authored-by: Johannes Christ <jc@jchri.st>
|
@thebeanogamer has implemented a few patches on top of the patchset here to work on production, which we will use for our monitoring, and merge by the next meeting. |
|
@dependabot rebase |
|
@thebeanogamer this is a pull request from jerbob, not dependabot, please be more considerate in the future. |
|
We're cleaning house and unfortunately this pull request has undergone a sad fate. With the conflicts I think it's more realistic to implement it partially separately. I will do so, but I will close this. Thank you for your work. You are sorely missed, Jeremiah. |
|
See #351 |
Adds django-healthcheck to the project dependencies, as well as the
relevant 'curl' command to the service's healthcheck. I've also added
a 'pg_isready' healthcheck to the database service, which allows us
to remove the netcat check from our entrypoint scripts.