Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick smaller changes from app restructure: Logging configuration and docstrings for Andromeda #253

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

jchristgit
Copy link
Collaborator

No description provided.

@jchristgit jchristgit added the documentation Improvements or additions to documentation label Feb 26, 2022
@jchristgit jchristgit requested review from 0xAda and jerbob February 26, 2022 20:55
@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b190108) 96.61% compared to head (327fa98) 96.61%.

Files Patch % Lines
src/andromeda/views.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         113      113           
  Lines        5322     5322           
  Branches      287      287           
=======================================
  Hits         5142     5142           
  Misses        146      146           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@0xAda 0xAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM'nt!

@jchristgit jchristgit force-pushed the pick-smaller-changes-from-app-restructure branch from b8e698f to a0bade4 Compare July 27, 2023 20:06
Copy link
Collaborator Author

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

@jchristgit jchristgit requested a review from 0xAda December 9, 2023 08:05
@jchristgit jchristgit force-pushed the pick-smaller-changes-from-app-restructure branch from a0bade4 to da69709 Compare December 16, 2023 17:44
@thebeanogamer thebeanogamer merged commit a5b87a1 into master Dec 16, 2023
6 of 7 checks passed
@thebeanogamer thebeanogamer deleted the pick-smaller-changes-from-app-restructure branch December 16, 2023 17:54
0xAda added a commit that referenced this pull request Sep 26, 2024
…docstrings for Andromeda (#253)

* Allow configuring django log level

* Add docstrings for the andromeda app

* Add docs for scripts

---------

Co-authored-by: Jeremiah Boby <mail@jeremiahboby.me>
Co-authored-by: 0xAda <me@ada.rip>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants