Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_superuser -> is_staff #88

Closed
wants to merge 1 commit into from
Closed

is_superuser -> is_staff #88

wants to merge 1 commit into from

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Mar 28, 2021

Fixes #69

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #88 (55bcf73) into master (d62ccb1) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   90.51%   90.58%   +0.06%     
==========================================
  Files         169      169              
  Lines        4344     4343       -1     
  Branches      229      229              
==========================================
+ Hits         3932     3934       +2     
+ Misses        358      356       -2     
+ Partials       54       53       -1     
Impacted Files Coverage Δ
src/polaris/client.py 38.70% <0.00%> (ø)
src/scorerecalculator/views.py 100.00% <ø> (ø)
src/config/views.py 62.06% <50.00%> (+6.89%) ⬆️
src/team/views.py 98.61% <100.00%> (ø)
src/config/config.py 84.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d62ccb1...55bcf73. Read the comment docs.

Copy link
Member

@Bentechy66 Bentechy66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5rN

@0xAda
Copy link
Contributor Author

0xAda commented Jun 9, 2021

this is done in #115

@0xAda 0xAda closed this Jun 9, 2021
@0xAda 0xAda deleted the cleanup/is_staff branch June 9, 2021 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistency between is_staff and is_superuser
2 participants