Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary bundling #24

Closed
cprecioso opened this issue Apr 3, 2016 · 1 comment
Closed

Unnecessary bundling #24

cprecioso opened this issue Apr 3, 2016 · 1 comment
Labels
enhancement

Comments

@cprecioso
Copy link

rcu is making npm grab eval2, tippex and vlq, but they aren't actually used, because rollup is set up to bundle them into the dist/ packages. So, either these dependencies should be moved to devDependencies, or rollup-plugin-node-resolve shouldn't be used any more.
Rich-Harris added a commit that referenced this issue Apr 4, 2016
@Rich-Harris
-> 0.8.0 - update deps, move bundled deps to devDependencies (#24)
c415462
@Rich-Harris Rich-Harris mentioned this issue Apr 4, 2016
Merged
Rich-Harris added a commit that referenced this issue Apr 4, 2016
@Rich-Harris
Merge pull request #25 from ractivejs/gh-24
a35352a 
Exclude bundled dependencies
@Rich-Harris
Copy link
Member

Good catch, thanks! Released a new version that moves them to devDependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cprecioso @Rich-Harris @fskreuz