Fix #16347: o+ sets maps as writable like oo+ #16381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
command
radare
reviewed
Mar 31, 2020
libr/core/cmd_open.c
Outdated
| RIOMap *map; | ||
| ls_foreach_prev (core->io->maps, iter, map) { | ||
| if (map->fd == fd) { | ||
| map->perm |= R_PERM_WX; |
There was a problem hiding this comment.
if the underlying fd doesnt permit W this will not be correct
There was a problem hiding this comment.
ok bcbec03 ... btw, tried this with a chmod -w bin and the error actually happened in r_core_file_open(), but the extra check appears harmless
kazarmy
force-pushed
the
o+-writable-maps-fix
branch
from
dee13ed
to
bcbec03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
o+now sets maps as writable likeoo+(dee13ed#diff-9423a86a7236062c0e9fbbf805a079cc). Code is fromoo+.Test plan
Travis and AppVeyor are green with attached test.
Closing issues
Closes #16347.