Fix shellcode customization #16384
Merged
Fix shellcode customization #16384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radare
requested changes
Mar 31, 2020
|
please address comments, rebase and add test |
radare
reviewed
Apr 4, 2020
|
Ping |
|
can you fix the indentation issues? i think we're good to merge this before adding support for the other archs |
|
otherwise ill move to 4.5 unless you ping back |
|
Hey, please excuse my late reaction. I was offline in the past week. I'll open a new pull request for more architectures and the test. |
|
cool! thanks! and welcome back |
radare
approved these changes
Apr 8, 2020
|
You may merge now. I'm currently preparing a proposal to refactor the shellcode compilation. |
Emi1305
pushed a commit
to Emi1305/radare2
that referenced
this pull request
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Currently, shellcode customization is not implemented for all architectures. This pull request implements this functionality for x86-64. I will add the test and further architectures in another pull request.
Test plan
Closing issues
closes #14648