Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty struct and add test ##types #16408

Merged
merged 1 commit into from Apr 3, 2020
Merged

Fix empty struct and add test ##types #16408

merged 1 commit into from Apr 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description
Move up the struct definition before the while loop so an empty struct could be defined.

Test plan

$ r2 -
[0x00000000]> "td struct Empty{};"
[0x00000000]> ts
Empty
[0x00000000]> "td struct Empty{int a;};"
[0x00000000]> ts
Empty

Closing issues
#16342

@radare radare added this to the 4.4.0 - pangolin milestone Apr 2, 2020
@github-actions github-actions bot added the command New commands requests, behaviour changes, removal label Apr 2, 2020
@radare radare marked this pull request as ready for review April 2, 2020 22:26
@radare
Copy link
Collaborator

radare commented Apr 2, 2020

Why it's WIP? looks good to me

@radare radare changed the title --WIP--: Fix empty struct and add test WIP - Fix empty struct and add test ##types Apr 2, 2020
@ghost ghost changed the title WIP - Fix empty struct and add test ##types Fix empty struct and add test ##types Apr 3, 2020
@radare radare merged commit 88d8357 into radareorg:master Apr 3, 2020
@ghost ghost deleted the fix_empty_struct branch April 3, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command New commands requests, behaviour changes, removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant