Add interactive mode to r2r #16466
Add interactive mode to r2r #16466
Conversation
| @@ -387,6 +397,19 @@ int main(int argc, char **argv) { | |||
| } | |||
| r_pvector_clear (&workers); | |||
|
|
|||
| ut64 seconds = (r_sys_now () - time_start) / 1000000; | |||
There was a problem hiding this comment.
you wrote that code in the first place :-P
There was a problem hiding this comment.
I think we should do that change in another pr, where we move some stuff to r_util.
binr/r2r/r2r.c
Outdated
| if (!test->cmds.value) { | ||
| return; | ||
| } | ||
| char *name; |
There was a problem hiding this comment.
maybe worth = NULL; in theory when returning -1 name will not be initialized, so the free below it will crash
binr/r2r/r2r.c
Outdated
| eprintf ("Failed to open tmp file\n"); | ||
| return; | ||
| } | ||
| write (fd, test->cmds.value, strlen (test->cmds.value)); |
There was a problem hiding this comment.
(void) the return on purpose or check the return value and report proper error in case it cant write
binr/r2r/r2r.c
Outdated
| } | ||
| size_t len = strlen (trimmed); | ||
| // strip all trailing newlines | ||
| while (len && trimmed[len - 1] == '\n') { |
There was a problem hiding this comment.
that wont work on CRLF files, also we have r_str apis for that
binr/r2r/r2r.c
Outdated
| // if it's multiline we want exactly one trailing newline | ||
| if (strchr (trimmed, '\n')) { | ||
| char *tmp = newcmds; | ||
| newcmds = r_str_newf ("%s\n", trimmed); |
There was a problem hiding this comment.
newcmds can be null and then strchr will crash
|
there are cornflakes in r2r.c now pls fix too |
|
Cornflakes are eaten and comets are addressed. |
The final nail in r2r.js' coffin.
Fixes #15662