Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16455 - iij asserts for ld-uclibc with a null import ##bin #16509

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

radare
Copy link
Collaborator

@radare radare commented Apr 9, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

listing imports on ld-uclibc results on 1 entry which is filled by zeros. maybe t shouldnt be there, but in case is there it shouldnt be asserting because of null strings.

Test plan

i added a test which shows the current output

Closing issues

fixes #16455

@radare radare added this to the 4.4.0 - pangolin milestone Apr 9, 2020
@radare radare requested a review from ret2libc April 9, 2020 22:24
@XVilka XVilka merged commit af51074 into master Apr 10, 2020
Emi1305 pushed a commit to Emi1305/radare2 that referenced this pull request Jul 12, 2020
…##bin (radareorg#16509)

* Fix asserts in `iij` for ld-uclibc with a null import ##bin
* Add test for `iij` on ld-uclibc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while parsing ELF MIPS imports
2 participants