Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16433 - Support movabs for x86_64's MOV r64, imm64 #16527

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

kazarmy
Copy link
Contributor

@kazarmy kazarmy commented Apr 11, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

This pr adds support for the movabs instruction, equivalent to the x86_64 MOV r64, imm64 instruction (opcode B8+ rd). This is consistent with both capstone (via the tests) and objdump:

objdump -D -b binary -m i386:x86-64 -M intel ./testbin
movabs
movabs_2

Test plan

Travis and AppVeyor are green.

Closing issues

Closes #16433.

Copy link
Collaborator

@radare radare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@radare radare added this to the 4.4.0 - pangolin milestone Apr 11, 2020
@kazarmy kazarmy merged commit 9227c67 into radareorg:master Apr 11, 2020
Emi1305 pushed a commit to Emi1305/radare2 that referenced this pull request Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rasm2 -b64 'mov rax, 0xdeadbeef' | rasm2 -d -b64 - doesn't round trip.
2 participants