Fixes #2856
Closed
Fixes #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1211,7 +1211,8 @@ R_API int r_core_serve(RCore *core, RIODesc *file) { | |||
| return -1; | |||
| if (c == NULL) { | |||
| eprintf ("rap: cannot accept\n"); | |||
| r_socket_close (c); | |||
| /*r_socket_close (c);*/ | |||
| r_socket_free (c); | |||
There was a problem hiding this comment.
Should be always r_socket_free or r_socket_close ? r_socket_close doesn't free the RSock structure and I understand that if it fails the structure should be freed
There was a problem hiding this comment.
freeing a socket should close it, but im not sure if this will produce a regression or not. but the correct or expected functionality should be this one.
This was referenced Jun 28, 2015
|
awsum <3 there are some little indentation issues, but meh, this is also happening in other places. thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if I don't break any test