add server side logging configurations #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-set-log-level-in-sdk-in-initialize
ShiCheng-Lu
force-pushed
the
shicheng/fence-1948-set-log-level-in-sdk-in-initialize
branch
2 times, most recently
from
832f6d8
to
e95bf77
Compare
ShiCheng-Lu
force-pushed
the
shicheng/fence-1948-set-log-level-in-sdk-in-initialize
branch
from
e95bf77
to
b23cdce
Compare
ShiCheng-Lu
force-pushed
the
shicheng/fence-1948-set-log-level-in-sdk-in-initialize
branch
from
e119e90
to
4e006fe
Compare
… of github.com:radarlabs/radar-sdk-android into shicheng/fence-1948-set-log-level-in-sdk-in-initialize
|
I will remove the publish keys for testing if everything else looks good |
| @@ -130,6 +131,8 @@ internal class RadarApiClient( | |||
| if (usage != null) { | |||
| queryParams.append("&usage=${usage}") | |||
| } | |||
| val clientSdkConfiguration = RadarSettings.getClientSdkConfiguration(context).toString() | |||
| queryParams.append("&clientSdkConfiguration=${URLEncoder.encode(clientSdkConfiguration, "utf-8")}") | |||
There was a problem hiding this comment.
just to confirm this is consistent with the iOS encoding?
Also a GET request can technically have a body, would we want to utilize that here?
| internal fun getLogLevel(context: Context): Radar.RadarLogLevel { | ||
| val logLevelInt = getSharedPreferences(context).getInt(KEY_LOG_LEVEL, 3) | ||
| val userDebug = getUserDebug(context) | ||
| return if (userDebug) Radar.RadarLogLevel.DEBUG else Radar.RadarLogLevel.fromInt(logLevelInt) | ||
| } | ||
|
|
||
| internal fun setLogLevel(context: Context, level: Radar.RadarLogLevel) { | ||
| val logLevelInt = level.value | ||
| getSharedPreferences(context).edit { putInt(KEY_LOG_LEVEL, logLevelInt) } | ||
| val sdkConfiguration = getClientSdkConfiguration(context) |
There was a problem hiding this comment.
echoing my sentiments from the ios PR, maybe move the syncing logic to the logger obj?
| fun setSdkConfiguration(context: Context, configuration: RadarSdkConfiguration?) { | ||
| Radar.logger.d("set SDK Configuration | sdkConfiguration = $configuration") | ||
| if (configuration != null) { | ||
| getSharedPreferences(context).edit { putInt(KEY_LOG_LEVEL, configuration.logLevel.value) } |
There was a problem hiding this comment.
I think we want to store the entire object?
There was a problem hiding this comment.
not needed for logLevel, added in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
android waypoint build:
https://expo.dev/accounts/radarlabs/projects/waypoint/builds/9adf68f2-2e37-4c40-844c-6389f63bed62
see #371