Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assign): fix overriding a nested object with null #112

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

aleclarson
Copy link
Member

@aleclarson aleclarson commented Jul 15, 2024

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Summary

Fix assign so a nested object can be replaced with null.

See the test case.

Related issue, if any:

sodiray/radash#373

For any code change,

  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Bundle impact

Status File Size Difference (%)
M src/object/assign.ts 431 -23 (-6%)

@aleclarson aleclarson merged commit 30c42e9 into main Jul 15, 2024
4 checks passed
@aleclarson aleclarson deleted the fix/assign-null branch July 15, 2024 19:04
Copy link

A new beta version 12.2.0-beta.4aac7d7 has been published to NPM. 🚀

To install:

pnpm add radashi@12.2.0-beta.4aac7d7

The radashi@beta tag also includes this PR.

See the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant