feat: use native AggregateError if available #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep the tests in one file. Use `vi.resetModules` to check for correct behavior when globalThis.AggregateError is undefined and when it‘s not.
- Inline the polyfill so it‘s not instantiated unless necessary.
- Rename the local const to `AggregateErrorOrPolyfill` then use `export { … as … }` to export it as `AggregateError`. This prevents ESBuild from renaming the polyfill to `AggregateError2`, which it does to prevent variable shadowing.
aleclarson
previously approved these changes
Jul 20, 2024
aleclarson
changed the title
|
Looks good now! Thanks for all the work you put into this. 👍 Btw, in the future, you should avoid sending PR from your |
|
A new beta version To install: pnpm add radashi@12.2.0-beta.313bfb4The 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements logic to use a native implementation if available instead of a polyfill.
Related issue
#75
Code changes
Question
To create my test, I had to create a separate file because I encountered issues using
vi.stubGlobalin the same file. I discovered this happens because Vitest uses the same workers per test file. Running tests simultaneously causes conflicts withglobalThissharing. More details can be found in this discussion: vitest-dev/vitest#1741. The workaround I found was to use two files. It’s not ideal, but it works. Any suggestions for a better solution are welcome.Does this PR introduce a breaking change?
No
Bundle impact
Calculating...