-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add castResult
function
#134
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
force-pushed
the
feat/toResult-fn
branch
from
July 22, 2024 23:31
7099c3e
to
f643d51
Compare
aleclarson
added
the
new feature
This PR adds a new function or extends an existing one
label
Jul 23, 2024
aleclarson
force-pushed
the
feat/toResult-fn
branch
from
July 23, 2024 16:45
f643d51
to
8435974
Compare
3 tasks
Closing this. The use cases are too limited, I think, and it adds unnecessary bloat to the other functions I tried using it in. I considered splitting the promise-handling into a new That said, I'll be refactoring the types of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publish
in this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>
.Summary
Add a
castResult
function for coercing an (error, value) pair into aResult
tuple (introduced by #132).CastResult
type is used in thecastResult
function's return type.Related issue, if any:
Merge #132 first!
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact
src/async/defer.ts
src/async/parallel.ts
src/async/tryit.ts
src/function/castResult.ts
src/typed/isResult.ts
Footnotes
Function size includes the
import
dependencies of the function. ↩