Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add withResolvers ponyfill #148

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Minhir
Copy link
Member

@Minhir Minhir commented Jul 30, 2024

Tip

The owner of this PR can publish a preview release by commenting /publish in this PR. Afterwards, anyone can try it out by running pnpm add radashi@pr<PR_NUMBER>.

Summary

Not sure if that one should be public util or radashi internal one.

Related issue, if any:

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed
  • Related benchmarks have been added or updated, if needed

Does this PR introduce a breaking change?

No

Bundle impact

Status File Size
A src/async/withResolvers.ts 114 1

Footnotes

  1. Function size includes the import dependencies of the function.

@Minhir Minhir requested a review from aleclarson as a code owner July 30, 2024 18:53
@Minhir Minhir mentioned this pull request Jul 30, 2024
3 tasks
@aleclarson
Copy link
Member

Not sure if that one should be public util or radashi internal one.

All functions in Radashi are public. It's one of our core principles currently. 😉

@aleclarson aleclarson changed the title Add withResolvers feat: add withResolvers ponyfill Jul 30, 2024
@aleclarson
Copy link
Member

Apologies for the delay. Been working on the Radashi website and its VSCode extension :)

I'm gonna use this PR to debug the "Bundle Impact" calculation (it shouldn't be an empty table here), but after that we can merge!

@aleclarson aleclarson merged commit 79f1ac7 into radashi-org:main Aug 14, 2024
7 checks passed
Copy link

A new beta version 12.2.0-beta.1ee40e2 has been published to NPM. 🚀

To install:

pnpm add radashi@12.2.0-beta.1ee40e2

The radashi@beta tag also includes this PR.

See the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants